gribozavr2 added a comment.

I can see it being useful for fix-its and source ranges, however I have a 
concern about it accidentally eating arguments that were supposed to go into a 
format string. For that, I second Aaron's suggestion to implement an extension 
for format strings. If you don't want to do that far, I think adding specific 
overloads for optional fix-its and optional source ranges would work, and won't 
trigger in unexpected situations.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D75714/new/

https://reviews.llvm.org/D75714



_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to