MyDeveloperDay added a comment.
you need documentation and release note changes too
================
Comment at: clang/unittests/Format/FormatTest.cpp:31
+class FormatTest
+ : public ::testing::Test { // FormatTest is a Fixture, data is reused
protected:
----------------
is this comment necessary?
================
Comment at: clang/unittests/Format/FormatTest.cpp:2440
TEST_F(FormatTest, FormatsExternC) {
- verifyFormat("extern \"C\" {\nint a;");
- verifyFormat("extern \"C\" {}");
+ verifyFormat("extern \"C\" {\nint a; /*2.1*/");
+ verifyFormat("extern \"C\" { /*2.2*/\n}");
----------------
why are you changing tests? where is the test that shows this works when a
comment isn't present?
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D75791/new/
https://reviews.llvm.org/D75791
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
