aaron.ballman added reviewers: aaron.ballman, rjmccall, erik.pilkington,
MadCoder.
aaron.ballman added a comment.
Herald added a subscriber: dexonsmith.
Adding some more knowledgeable reviewers for comments on your RFC. I pointed
out a few minor nits, but I'll hold off on a technical review until the
ObjC-specific details are worked out and there is buy-in on the feature.
================
Comment at: clang/include/clang/AST/DeclObjC.h:2197
+ /// True if the protocol is tagged as objc_static_protocol
+ bool isStaticProtocol() const;
----------------
Comments should be properly punctuated (missing a full stop at the end of the
sentence), here and elsewhere.
================
Comment at: clang/lib/Sema/SemaDeclAttr.cpp:2609
+ const ParsedAttr &AL) {
+ if (S.getLangOpts().ObjCRuntime.allowsStaticProtocols()) {
+ handleSimpleAttribute<ObjCStaticProtocolAttr>(S, D, AL);
----------------
This should be implemented via a custom `LangOpt` in `Attr.td`
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D75574/new/
https://reviews.llvm.org/D75574
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
