sammccall marked an inline comment as done.
sammccall added a comment.
> I'll make a proposal on https://github.com/clangd/clangd/issues/241 for a bit
> more visibility.
OK, I wrote a bunch of stuff there (twice, laptop crashed, grr...)
I'll put this briefly on hold to see what you/others think there - e.g. the
real-identifier bit is best decided with the final plan in mind.
================
Comment at: clang-tools-extra/clangd/unittests/XRefsTests.cpp:871
+TEST(LocateSymbol, NearbyIdentifier) {
+ const char *Tests[] = {
+ R"cpp(
----------------
nridge wrote:
> Tangentially related, but what do you think about the issue I raised in [this
> mailing list
> thread](https://lists.llvm.org/pipermail/clangd-dev/2019-November/000579.html)
> about testcase style?
Posted a reply on the thread. TL;DR:
- I hate that too
- the style brings several benefits
- I don't know what would be better that's available
- but we could probably build something
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D75479/new/
https://reviews.llvm.org/D75479
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
