kadircet accepted this revision.
kadircet added a comment.
This revision is now accepted and ready to land.
LGTM, thanks for doing this!
================
Comment at: clang-tools-extra/clangd/CodeComplete.cpp:1378
Scopes.AccessibleScopes =
- visibleNamespaces(Content.take_front(Offset), Style);
+ visibleNamespaces(Content.take_front(Offset), LangOpts);
for (std::string &S : Scopes.AccessibleScopes)
----------------
nit: please inline
================
Comment at: clang-tools-extra/clangd/CodeComplete.cpp:1776
semaCodeComplete(
- std::make_unique<SignatureHelpCollector>(Options, Index, Result),
- Options,
+ std::make_unique<SignatureHelpCollector>(Options, Index, Result),
Options,
{FileName, Command, Preamble, Contents, *Offset, std::move(VFS)});
----------------
nit: formatting change could you please revert ?
================
Comment at: clang-tools-extra/clangd/unittests/SourceCodeTests.cpp:219
+ EXPECT_THAT_EXPECTED(
+ positionToOffset(File, position(L.Number, L.Length + 1)),
+ llvm::HasValue(L.Offset + L.Length));
----------------
nit: formatting change could you please revert ?
================
Comment at: clang-tools-extra/clangd/unittests/SourceCodeTests.cpp:455
-TEST(SourceCodeTests, IsInsideMainFile){
+TEST(SourceCodeTests, IsInsideMainFile) {
TestTU TU;
----------------
nit: formatting change could you please revert ?
================
Comment at: clang-tools-extra/clangd/unittests/SourceCodeTests.cpp:474
auto AST = TU.build();
- const auto& SM = AST.getSourceManager();
+ const auto &SM = AST.getSourceManager();
auto DeclLoc = [&AST](llvm::StringRef Name) {
----------------
nit: formatting change could you please revert ?
================
Comment at: clang-tools-extra/clangd/unittests/SourceCodeTests.cpp:574
auto AST = TU.build();
- const auto& SM = AST.getSourceManager();
+ const auto &SM = AST.getSourceManager();
----------------
nit: formatting change could you please revert ?
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D75716/new/
https://reviews.llvm.org/D75716
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
