rnk added a comment. Looks good, but we should add a test.
I can push this for you and even give attribution (hooray, git!), but I think you have enough uploaded code reviews that you could request push access as described here: https://llvm.org/docs/DeveloperPolicy.html#new-contributors Link to all the phab issues you have opened to show contributions. ================ Comment at: clang/test/SemaCXX/MicrosoftExtensions.cpp:214 b = reinterpret_cast<bool>(ptr); // expected-error {{cast from pointer to smaller type 'bool' loses information}} } ---------------- Can you please add a test for the `void*` diagnostic to exercise the other side of the ternary? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75708/new/ https://reviews.llvm.org/D75708 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
