martong added inline comments.
================ Comment at: clang/lib/AST/ASTImporter.cpp:7918 + + return nullptr; +} ---------------- I think ``` return make_error<ImportError(ImportError::UnsupportedConstruct); ``` would be more appropriate here as this expresses that we do not support every aspect yet. On the other hand a nullptr could be dereferenced later and thus could cause an unwanted crash. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64464/new/ https://reviews.llvm.org/D64464 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
