yusra.syeda added a comment.
Overall the patch LGTM, aside from 1 change we may want to make.
================
Comment at: clang/lib/CodeGen/ItaniumCXXABI.cpp:531
+
+ bool isCXXGlobalInitAndDtorFuncInternal() const override { return false; }
+
----------------
Perhaps adding a check to see if the OS is AIX before setting linkage to
external will be useful here.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D74166/new/
https://reviews.llvm.org/D74166
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
