sammccall accepted this revision.
sammccall added inline comments.
This revision is now accepted and ready to land.
================
Comment at: clang-tools-extra/clangd/Selection.cpp:612
+ // underlying TypeLoc.
+ // FIXME: Unfortunately this doesn't work, even though
RecursiveASTVisitor
+ // traverses the underlying TypeLoc inside DeclarationName, it is null
for
----------------
can you check this at HEAD?
IIRC this was related to the reason kythe was failing to report constructors as
references to the class, which is now fixed. But I don't know if they fixed the
AST or worked around it.
================
Comment at: clang-tools-extra/clangd/unittests/HoverTests.cpp:342
}},
- {"class X { operator [[in^t]](); };",
+ {"class X { operator [[^X]](); };",
[](HoverInfo &HI) {
----------------
want to keep the conversion operator test too? (by pointing at `operator`)
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D75106/new/
https://reviews.llvm.org/D75106
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
