krasimir accepted this revision.
krasimir added inline comments.
This revision is now accepted and ready to land.
================
Comment at: clang/lib/Format/TokenAnnotator.cpp:376
+
+ // Chains [] in of `identifier[i][j][k]` are not attributes.
+ if (Tok.Previous && Tok.Previous->is(tok::r_square)) {
----------------
nit: `// Chains of [] in ...`
================
Comment at: clang/unittests/Format/FormatTestCSharp.cpp:626
+ // Do not format array subscript operators as attributes.
+ verifyFormat(R"(if (someThings[index].Contains(myThing)) {)", Style);
+ verifyFormat(R"(if (someThings[i][j][k].Contains(myThing)) {)", Style);
----------------
please add a `}` at the end of this examples so that the braces are balanced,
otherwise the examples read as incomplete.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D75517/new/
https://reviews.llvm.org/D75517
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
