xazax.hun added a comment. Other than a nit looks good to me but wait for @NoQ before committing.
================ Comment at: clang/include/clang/StaticAnalyzer/Core/PathSensitive/CallEvent.h:208 + SValBuilder &getSValBuilder() const { + return State->getStateManager().getSValBuilder(); ---------------- Since `SValBuilder` has relatively little to do with call events I am kind of surprised seeing this here. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75431/new/ https://reviews.llvm.org/D75431 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits