alexfh added a comment. In D75441#1901071 <https://reviews.llvm.org/D75441#1901071>, @gribozavr2 wrote:
> > I think my preference is to go with isLanguageVersionSupported() and not > > use base classes. > > +1, I can see this working, but the introduction of new concepts does not > seem like it pulls its weight given the tiny amount of boilerplate that they > eliminate. +1, I'm definitely against adding base classes for supported language versions. The increase in the API surface doesn't seem to pay off here. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75441/new/ https://reviews.llvm.org/D75441 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
