john.brawn marked 6 inline comments as done. john.brawn added inline comments.
================ Comment at: clang/docs/ClangPlugins.rst:89 +The members of ``ParsedAttrInfo`` that a plugin attribute must define are: + * ``AttrKind``, which must be set to ``ParsedAttr::NoSemaHandlerAttribute``. + * ``Spellings``, which must be populated with the attribute syntaxes that are ---------------- aaron.ballman wrote: > If it must always be this one specific value, why do we make users set it > manually instead of setting it automatically for them? I've adjusted ParsedAttrInfo to default to NoSemaHandlerAttr. ================ Comment at: clang/docs/ClangPlugins.rst:105 + target. + Putting it all together ---------------- aaron.ballman wrote: > It might also be nice to link to the example code from D31343 from the > documentation to help get users started. e.g., "To see a working example of > an attribute plugin, see clang/examples/Attribute/Attribute.cpp" with a link > to the git repo source viewer for that file. WDYT? I'll add that as part of D31343. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D31342/new/ https://reviews.llvm.org/D31342 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
