balazske added a comment.

Is it sure that the signedness in the ranges is handled correctly? The EOF is a 
negative value but the `RangeInt` is unsigned type. The `tryExpandAsInteger` 
returns `int` too that is put into an unsigned `RangeInt` later. Probably it is 
better to use `APSInt` for the ranges?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D73898/new/

https://reviews.llvm.org/D73898



_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to