hans added a comment.

I also just noticed that this broke the Chromium build, see the attached 
reproducer at https://bugs.chromium.org/p/chromium/issues/detail?id=1057559#c1

clang++: /work/llvm.monorepo/clang/lib/AST/ExprConstant.cpp:14013: llvm::APSInt 
clang::Expr::EvaluateKnownConstInt(const clang::ASTContext &, 
SmallVectorImpl<clang::PartialDiagnosticAt> *) const: Assertion 
`!isValueDependent() && "Expression evaluator can't be called on a dependent 
expression."' failed.

#10 0x00000000046eb71d clang::Expr::EvaluateKnownConstInt(clang::ASTContext 
const&, llvm::SmallVectorImpl<std::pair<clang::SourceLocation, 
clang::PartialDiagnostic> >*) const 
(../../../../llvm.monorepo/build.release/bin/clang+++0x46eb71d)
#11 0x00000000027875de 
clang::CodeGen::CGDebugInfo::CollectTemplateParams(clang::TemplateParameterList 
const*, llvm::ArrayRef<clang::TemplateArgument>, llvm::DIFile*) 
(../../../../llvm.monorepo/build.release/bin/clang+++0x27875de)
#12 0x000000000278f67b 
clang::CodeGen::CGDebugInfo::CreateLimitedType(clang::RecordType const*) 
(../../../../llvm.monorepo/build.release/bin/clang+++0x278f67b)
#13 0x000000000278a2d1 
clang::CodeGen::CGDebugInfo::getOrCreateLimitedType(clang::RecordType const*, 
llvm::DIFile*) (../../../../llvm.monorepo/build.release/bin/clang+++0x278a2d1)
#14 0x000000000278980b 
clang::CodeGen::CGDebugInfo::CreateTypeDefinition(clang::RecordType const*) 
(../../../../llvm.monorepo/build.release/bin/clang+++0x278980b)
#15 0x000000000277eb15 
clang::CodeGen::CGDebugInfo::getOrCreateType(clang::QualType, llvm::DIFile*) 
(../../../../llvm.monorepo/build.release/bin/clang+++0x277eb15)
#16 0x0000000002782c58 
clang::CodeGen::CGDebugInfo::CreateType(clang::TypedefType const*, 
llvm::DIFile*) (../../../../llvm.monorepo/build.release/bin/clang+++0x2782c58)
#17 0x000000000277eb15 
clang::CodeGen::CGDebugInfo::getOrCreateType(clang::QualType, llvm::DIFile*) 
(../../../../llvm.monorepo/build.release/bin/clang+++0x277eb15)
#18 0x0000000002782a5f 
clang::CodeGen::CGDebugInfo::CreateType(clang::TypedefType const*, 
llvm::DIFile*) (../../../../llvm.monorepo/build.release/bin/clang+++0x2782a5f)
#19 0x000000000277eb15 
clang::CodeGen::CGDebugInfo::getOrCreateType(clang::QualType, llvm::DIFile*) 
(../../../../llvm.monorepo/build.release/bin/clang+++0x277eb15)
#20 0x000000000279a13d 
clang::CodeGen::CGDebugInfo::EmitExplicitCastType(clang::QualType) 
(../../../../llvm.monorepo/build.release/bin/clang+++0x279a13d)
#21 0x0000000002a26632 clang::StmtVisitorBase<std::add_pointer, (anonymous 
namespace)::ScalarExprEmitter, llvm::Value*>::Visit(clang::Stmt*) 
(../../../../llvm.monorepo/build.release/bin/clang+++0x2a26632)
#22 0x0000000002a32e14 (anonymous 
namespace)::ScalarExprEmitter::VisitCastExpr(clang::CastExpr*) 
(../../../../llvm.monorepo/build.release/bin/clang+++0x2a32e14)
#23 0x0000000002a1e3c5 
clang::CodeGen::CodeGenFunction::EmitScalarExpr(clang::Expr const*, bool) 
(../../../../llvm.monorepo/build.release/bin/clang+++0x2a1e3c5)
#24 0x00000000028e8257 
clang::CodeGen::CodeGenFunction::EmitAtomicExpr(clang::AtomicExpr*) 
(../../../../llvm.monorepo/build.release/bin/clang+++0x28e8257)
...


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D73462/new/

https://reviews.llvm.org/D73462



_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to