njames93 added a comment. In D75289#1896929 <https://reviews.llvm.org/D75289#1896929>, @Eugene.Zelenko wrote:
> In D75289#1896925 <https://reviews.llvm.org/D75289#1896925>, @njames93 wrote: > > > In D75289#1896902 <https://reviews.llvm.org/D75289#1896902>, > > @Eugene.Zelenko wrote: > > > > > Language and/or its standard is checked in other places too. Should all > > > similar places be refactored? > > > > > > They should but I feel they should be in follow up patches, the only reason > > MakeSmartPtrCheck is in here is because by coincidence it used the same > > name as what I planned and I got a compile warning about it. > > I also don't know exactly where all occurrences are. > > > Just grep for //getLangOpts()//. Thanks for that tip, I've put the full implementation in a child revision. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75289/new/ https://reviews.llvm.org/D75289 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
