MaskRay added inline comments.
================ Comment at: clang/test/Driver/clang_f_opts.c:15 // CHECK-OPTIONS2: -fshort-enums -// CHECK-OPTIONS2: -fno-common +// CHECK-OPTIONS2-NOT: -fcommon // CHECK-OPTIONS2: -fno-show-source-location ---------------- I think such NOT patterns should just be deleted. (Note that `NOT` patterns tend to be insufficient due to order reasons) `-fcommon` is a minority now. We only need to test it for an OS/Arch that really needs it (currently no). CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75056/new/ https://reviews.llvm.org/D75056 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
