vingeldal added a comment.

> - how do we either not warn on this by default or how does the user tell us 
> to not warn on it (without requiring them to jump through hoops like changing 
> the types of the arguments)?

-I'v used comments in the source code to tell the tool to ignore cases that I'v 
identified as false positives. That has worked without any issues for me and I 
wouldn't say it's a hassle. Is that no longer supported in clang tidy or was I 
using another tool and just projected that memory on clang-tidy?
I'm confident that clang-format atleast has a means of locally suppressing 
rules.

> I'd also want to see some data as to how often this check warns with true 
> positives over a large, real-world code base (like LLVM).

-I could do this. I agree it makes sense to look at actual data on how much 
this detects and how much is noise.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D74463/new/

https://reviews.llvm.org/D74463



_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to