bruno added a comment.

Thanks for working on this.

> I'm not sure how (or if it's possible) to add a test that would demonstrate 
> the before/after here. Happy to take advice!

Yea, those are some times hard. Did you try to write a unittest that hits the 
assertion and trigger this case? Perhaps 
`clang/unittests/Frontend/PCHPreambleTest.cpp` would be a good example to start 
off.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D74795/new/

https://reviews.llvm.org/D74795



_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
  • [PATCH] D74795: Ma... Neil MacIntosh via Phabricator via cfe-commits
    • [PATCH] D7479... Duncan P. N. Exon Smith via Phabricator via cfe-commits
    • [PATCH] D7479... Bruno Cardoso Lopes via Phabricator via cfe-commits

Reply via email to