sammccall added a comment.

Specifically, we can't change the return value for any valid utf-8 string (see 
tests).

Instead, where we currently assert length is between 2 and 4, you could change 
that to an if and treat it (arbitrarily) as a one-utf-8-byte, 
one-utf-16-code-unit character.

This new behavior should have a test.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D74731/new/

https://reviews.llvm.org/D74731



_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to