teemperor added a comment.
This broke the LLVM_ENABLE_MODULES build because it introduces a cyclic
dependency between LLVM_IR and LLVM_intrinsic_gen:
FAILED:
tools/lld/lib/ReaderWriter/MachO/CMakeFiles/lldMachO.dir/MachONormalizedFileBinaryReader.cpp.o
/Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/c++
-DGTEST_HAS_RTTI=0 -D_DEBUG -D__STDC_CONSTANT_MACROS -D__STDC_FORMAT_MACROS
-D__STDC_LIMIT_MACROS -Itools/lld/lib/ReaderWriter/MachO
-I/Users/teemperor/1llvm/llvm-project/lld/lib/ReaderWriter/MachO
-I/Users/teemperor/1llvm/llvm-project/lld/include -Itools/lld/include
-I/Applications/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX10.15.sdk/usr/include/libxml2
-Iinclude -I/Users/teemperor/1llvm/llvm-project/llvm/include
-I/Users/teemperor/1llvm/llvm-project/lld/lib/ReaderWriter/MachO/. -fPIC
-fvisibility-inlines-hidden -Werror=date-time
-Werror=unguarded-availability-new -fmodules
-fmodules-cache-path=/Users/teemperor/1llvm/rel/module.cache -fcxx-modules
-Wall -Wextra -Wno-unused-parameter -Wwrite-strings -Wcast-qual
-Wmissing-field-initializers -pedantic -Wno-long-long -Wimplicit-fallthrough
-Wcovered-switch-default -Wno-noexcept-type -Wnon-virtual-dtor
-Wdelete-non-virtual-dtor -Wstring-conversion -fdiagnostics-color -O3
-isysroot
/Applications/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX10.15.sdk
-fno-exceptions -fno-rtti -UNDEBUG -std=c++14 -MD -MT
tools/lld/lib/ReaderWriter/MachO/CMakeFiles/lldMachO.dir/MachONormalizedFileBinaryReader.cpp.o
-MF
tools/lld/lib/ReaderWriter/MachO/CMakeFiles/lldMachO.dir/MachONormalizedFileBinaryReader.cpp.o.d
-o
tools/lld/lib/ReaderWriter/MachO/CMakeFiles/lldMachO.dir/MachONormalizedFileBinaryReader.cpp.o
-c
/Users/teemperor/1llvm/llvm-project/lld/lib/ReaderWriter/MachO/MachONormalizedFileBinaryReader.cpp
While building module 'LLVM_Object' imported from
/Users/teemperor/1llvm/llvm-project/lld/lib/ReaderWriter/MachO/MachONormalizedFileBinaryReader.cpp:36:
While building module 'LLVM_IR' imported from
/Users/teemperor/1llvm/llvm-project/llvm/include/llvm/Object/IRSymtab.h:29:
While building module 'LLVM_intrinsic_gen' imported from
/Users/teemperor/1llvm/llvm-project/llvm/include/llvm/IR/IRBuilderFolder.h:18:
In file included from <module-includes>:1:
/Users/teemperor/1llvm/llvm-project/llvm/include/llvm/IR/Argument.h:19:10:
fatal error: cyclic dependency in module 'LLVM_IR': LLVM_IR ->
LLVM_intrinsic_gen -> LLVM_IR
#include "llvm/IR/Value.h"
^
While building module 'LLVM_Object' imported from
/Users/teemperor/1llvm/llvm-project/lld/lib/ReaderWriter/MachO/MachONormalizedFileBinaryReader.cpp:36:
While building module 'LLVM_IR' imported from
/Users/teemperor/1llvm/llvm-project/llvm/include/llvm/Object/IRSymtab.h:29:
In file included from <module-includes>:13:
/Users/teemperor/1llvm/llvm-project/llvm/include/llvm/IR/IRBuilderFolder.h:18:10:
fatal error: could not build module 'LLVM_intrinsic_gen'
#include "llvm/IR/InstrTypes.h"
~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~
While building module 'LLVM_Object' imported from
/Users/teemperor/1llvm/llvm-project/lld/lib/ReaderWriter/MachO/MachONormalizedFileBinaryReader.cpp:36:
In file included from <module-includes>:4:
/Users/teemperor/1llvm/llvm-project/llvm/include/llvm/Object/IRSymtab.h:29:10:
fatal error: could not build module 'LLVM_IR'
#include "llvm/IR/GlobalValue.h"
~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~
/Users/teemperor/1llvm/llvm-project/lld/lib/ReaderWriter/MachO/MachONormalizedFileBinaryReader.cpp:36:10:
fatal error: could not build module 'LLVM_Object'
#include "llvm/Object/MachO.h"
~~~~~~~~^~~~~~~~~~~~~~~~~~~~~
4 errors generated.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D73835/new/
https://reviews.llvm.org/D73835
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
