yroux marked 2 inline comments as done. yroux added a comment. Thanks for the comments Sam,
Thumb1 is disabled in this version (see inline comment). The is to bundle Machine Outliner to -Oz like it was done for AArch64, but here it just run when the flags are used (-moutline for clang or -enable-machine-outliner for llc) and not all the time. Ok I'll try see if I can split it on the outlining kind as you suggest. ================ Comment at: llvm/lib/CodeGen/MachineOutliner.cpp:1159 + MF.getProperties().reset(MachineFunctionProperties::Property::IsSSA); + MF.getProperties().set(MachineFunctionProperties::Property::NoPHIs); + MF.getProperties().set(MachineFunctionProperties::Property::NoVRegs); ---------------- samparker wrote: > Looks like these should these be set in getRequiredProperties. Maybe @paquette can comment on that ================ Comment at: llvm/lib/Target/ARM/ARMBaseInstrInfo.cpp:5800-5802 + // FIXME: Thumb1 outlining is not handled + if (MF.getInfo<ARMFunctionInfo>()->isThumb1OnlyFunction()) + return false; ---------------- Thumb1 is disabled here. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D57054/new/ https://reviews.llvm.org/D57054 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
