balazske added inline comments.
================ Comment at: clang/include/clang/StaticAnalyzer/Core/PathSensitive/CheckerHelpers.h:17 #include "clang/AST/Stmt.h" +#include "clang/Lex/Preprocessor.h" +#include "llvm/ADT/Optional.h" ---------------- We do not need to include Preprocessor.h here (fwd declaration is enough). ================ Comment at: clang/include/clang/StaticAnalyzer/Core/PathSensitive/CheckerHelpers.h:70 +/// token for an integer. If we cannot parse the value then None is returned. +llvm::Optional<int> TryExpandAsInteger(StringRef Macro, const Preprocessor &PP); ---------------- Name should begin with lowercase letter? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74473/new/ https://reviews.llvm.org/D74473 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
