Charusso accepted this revision.
Charusso added a comment.
This revision is now accepted and ready to land.
Thanks! I would mention in the Summary the necessary flags to perform
index-only output. (May write some release notes?)
That option sounds very strange, but I like it. For example to run only
necessary custom tests one could write:
-analyzer-checker=core,unix,custom.checkers \
-analyzer-config silence-checkers="core;unix"
================
Comment at: clang/tools/scan-build/bin/scan-build:953
+ my $ExitStatus = shift;
+
+ if (defined $Options{OutputFormat}) {
----------------
May inject `Diag "Analysis run complete.\n";` here?
================
Comment at: clang/tools/scan-build/bin/scan-build:976
+
+ if ($Options{ExitStatusFoundBugs}) {
+ exit 1 if ($NumBugs > 0);
----------------
If we stick to printing information to the user: `Diag "No bugs found.\n"`?.
================
Comment at: clang/tools/scan-build/bin/scan-build:1303
+ from existing report.html files. Useful for making a custom Static Analyzer
+ integration into a build system that isn't otherwise supported by
scan-build.
+
----------------
What about `--index-only`?
================
Comment at: clang/tools/scan-build/bin/scan-build:1618
+ DieDiag("Only one of '-o' or '--generate-index' can be specified.\n");
+ }
+
----------------
I may smash this duplicated error-handling above in one if-stmt, given that the
options are correlate with each other.
Repository:
rC Clang
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D74467/new/
https://reviews.llvm.org/D74467
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
