rnk accepted this revision.
rnk added a comment.
This revision is now accepted and ready to land.
Herald added a reviewer: rriddle.
Herald added a subscriber: Joonsoo.
This revision now requires review to proceed.
lgtm
================
Comment at: llvm/lib/Support/Unix/Threading.inc:273
+
+int computeHostNumPhysicalThreads() {
+#if defined(HAVE_SCHED_GETAFFINITY) && defined(HAVE_CPU_COUNT)
----------------
aganea wrote:
> rnk wrote:
> > I'm not sure it makes sense to say "physical threads". I think "physical
> > cores" was meant to distinguish between hardware threads and cores.
> > Describing hardware execution resources as physical or non-physical isn't
> > very precise or meaningful in the first place, but I don't think it should
> > apply to hyper threads.
> `computeHostNumHardwareThreads()` ?
lgtm
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D71775/new/
https://reviews.llvm.org/D71775
_______________________________________________
cfe-commits mailing list
[email protected]
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
