efriedma added a comment. This is sort of a large number of functional changes, but it's probably okay to skip test coverage for all the simple getNumElements->getElementCount changes; it's obvious it can't break anything.
================ Comment at: llvm/include/llvm/Analysis/Utils/Local.h:67 + OpC = ConstantVector::getSplat( + cast<VectorType>(IntIdxTy)->getElementCount(), OpC); ---------------- getVectorElementCount? (Same in other places.) ================ Comment at: llvm/lib/IR/Constants.cpp:2129 + if (EltCount.Min != 0) + ReqTy = VectorType::get(ReqTy, EltCount); ---------------- I'd like to see test coverage for the GEP changes here, since the logic is relatively intricate. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74386/new/ https://reviews.llvm.org/D74386 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
