lebedev.ri added a comment. In D68049#1870401 <https://reviews.llvm.org/D68049#1870401>, @tmsriram wrote:
> In D68049#1870094 <https://reviews.llvm.org/D68049#1870094>, @tmsriram wrote: > > > In D68049#1868623 <https://reviews.llvm.org/D68049#1868623>, @MaskRay wrote: > > > > > > In D68049#1865967 <https://reviews.llvm.org/D68049#1865967>, @MaskRay > > > > wrote: > > > > If you don't mind, I can push a Diff to this Differential which will > > > > address these review comments. > > > > > > I can't because I can't figure out the patch relationship... > > > > > > First, this patch does not build on its own. I try applying D68063 > > > <https://reviews.llvm.org/D68063> first, then this patch. It still does > > > not compile.. > > > > > This should work now. Please apply D68063 <https://reviews.llvm.org/D68063> > first and then this one. Thanks! Please can you specify all those patch relations by marking patches as parent/child in phab ui? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68049/new/ https://reviews.llvm.org/D68049 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
