stevewan added inline comments.
================ Comment at: clang/lib/CodeGen/ItaniumCXXABI.cpp:520 + +class XLClangCXXABI final : public ItaniumCXXABI { +public: ---------------- The class name here is inconsistent with how our ABI kind was called previously, as David pointed out. Maybe rename the ABI kind `XLClang`? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74015/new/ https://reviews.llvm.org/D74015 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits