This revision was automatically updated to reflect the committed changes. Closed by commit rGf0fd852fcd05: Fix SFINAE in CFG.cpp. (authored by jlebar).
Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74412/new/ https://reviews.llvm.org/D74412 Files: clang/lib/Analysis/CFG.cpp Index: clang/lib/Analysis/CFG.cpp =================================================================== --- clang/lib/Analysis/CFG.cpp +++ clang/lib/Analysis/CFG.cpp @@ -720,10 +720,10 @@ // These sorts of call expressions don't have a common superclass, // hence strict duck-typing. template <typename CallLikeExpr, - typename = typename std::enable_if< - std::is_same<CallLikeExpr, CallExpr>::value || - std::is_same<CallLikeExpr, CXXConstructExpr>::value || - std::is_same<CallLikeExpr, ObjCMessageExpr>::value>> + typename = std::enable_if_t< + std::is_base_of<CallExpr, CallLikeExpr>::value || + std::is_base_of<CXXConstructExpr, CallLikeExpr>::value || + std::is_base_of<ObjCMessageExpr, CallLikeExpr>::value>> void findConstructionContextsForArguments(CallLikeExpr *E) { for (unsigned i = 0, e = E->getNumArgs(); i != e; ++i) { Expr *Arg = E->getArg(i);
Index: clang/lib/Analysis/CFG.cpp =================================================================== --- clang/lib/Analysis/CFG.cpp +++ clang/lib/Analysis/CFG.cpp @@ -720,10 +720,10 @@ // These sorts of call expressions don't have a common superclass, // hence strict duck-typing. template <typename CallLikeExpr, - typename = typename std::enable_if< - std::is_same<CallLikeExpr, CallExpr>::value || - std::is_same<CallLikeExpr, CXXConstructExpr>::value || - std::is_same<CallLikeExpr, ObjCMessageExpr>::value>> + typename = std::enable_if_t< + std::is_base_of<CallExpr, CallLikeExpr>::value || + std::is_base_of<CXXConstructExpr, CallLikeExpr>::value || + std::is_base_of<ObjCMessageExpr, CallLikeExpr>::value>> void findConstructionContextsForArguments(CallLikeExpr *E) { for (unsigned i = 0, e = E->getNumArgs(); i != e; ++i) { Expr *Arg = E->getArg(i);
_______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits