rogfer01 added inline comments.
================ Comment at: llvm/lib/Frontend/OpenMP/OMPIRBuilder.cpp:114 + + // Add some known attributes to the outlined function. + Function *OutlinedFn = Extractor.extractCodeRegion(CEAC); ---------------- This comment seems misplaced now. ================ Comment at: llvm/lib/Frontend/OpenMP/OMPIRBuilder.cpp:654-655 + Instruction *PreFiniTI = PRegPreFiniBB->getTerminator(); + OuterFn->dump(); + PreFiniTI->dump(); + assert(PreFiniTI->getNumSuccessors() == 1 && ---------------- I think you forgot to wrap these in a `LLVM_DEBUG` ================ Comment at: llvm/lib/Frontend/OpenMP/OMPIRBuilder.cpp:663 - return AfterIP; + InsertPointTy ExitIP(UI->getParent(), UI->getParent()->end()); + UI->eraseFromParent(); ---------------- This used to be called `AfterIP`. Probably the exact name is not that important but the unit tests still use `AfterIP` so I'd suggest to keep both names in sync. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74372/new/ https://reviews.llvm.org/D74372 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
