martong marked 2 inline comments as done. martong added a comment. Herald added a subscriber: steakhal.
Ping @NoQ ================ Comment at: clang/lib/StaticAnalyzer/Checkers/StdLibraryFunctionsChecker.cpp:42-49 // The following standard C functions are currently supported: // // fgetc getline isdigit isupper // fread isalnum isgraph isxdigit // fwrite isalpha islower read // getc isascii isprint write // getchar isblank ispunct ---------------- Szelethus wrote: > martong wrote: > > Szelethus wrote: > > > I would prefer to just have a checker option that could print out the > > > currently modeled function rather than these lines of a recipe for > > > outdated comments. > > Yes I agree, especially because I am planning to add a plethora of new > > functions in the future. I think that would be the appropriate time to > > implement the checker option. > Totally agreed! Thank you for the cleanup! No, thanks for the review! :) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D73897/new/ https://reviews.llvm.org/D73897 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
