aganea marked an inline comment as done.
aganea added inline comments.

================
Comment at: clang/lib/Lex/Pragma.cpp:1148
 
+#ifdef __clang__
+  __attribute__((optnone))
----------------
Would it be better if we had something like `LLVM_[DISABLE|ENABLE]_OPT` in 
`Compiler.h` instead of the #ifdefs? That would map to `#pragma clang optimize 
[off|on]` (and corresponding #pragma on MSVC/GCC). Note that there's no way I 
know of to disable optimizations on a per-function basis on MSVC.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D74229/new/

https://reviews.llvm.org/D74229



_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to