kbobyrev accepted this revision.
kbobyrev added inline comments.
This revision is now accepted and ready to land.
================
Comment at: clang-tools-extra/clangd/index/SymbolCollector.cpp:595
DeclarationName Name = DeclAndRef.first->getDeclName();
- bool Spelled = IdentifierToken && Name.isIdentifier() &&
+ auto NameKind = Name.getNameKind();
+ bool IsTargetKind = NameKind == DeclarationName::Identifier ||
----------------
nit: const auto?
================
Comment at: clang-tools-extra/clangd/unittests/SymbolCollectorTests.cpp:752
+ const auto ID = SymbolAndRefs.first;
+ if (!(ID == TargetID))
+ continue;
----------------
nit: maybe add operator != to SymbolKind instead?
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D74125/new/
https://reviews.llvm.org/D74125
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
