kadircet accepted this revision.
kadircet added a comment.
This revision is now accepted and ready to land.
thanks, lgtm!
================
Comment at: clang-tools-extra/clangd/CodeComplete.cpp:1007
Result.Quality = Signal;
- Result.IDForDoc =
- Result.Signature.documentation.empty() && Candidate.getFunction()
- ? clangd::getSymbolID(Candidate.getFunction())
- : None;
+ if (Result.Signature.documentation.empty() && Candidate.getFunction()) {
+ // Computing USR caches linkage, which may change after code completion.
----------------
nit: maybe decrease # of `Candidate.getFunction`s via
```
if(!doc.empty())
return Result;
if(const auto *FD = Candidate->getFunction()) {
....
}
```
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D73960/new/
https://reviews.llvm.org/D73960
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
