Charusso marked 2 inline comments as done.
Charusso added inline comments.

================
Comment at: 
clang/include/clang/StaticAnalyzer/Core/PathSensitive/SValHasDescendant.h:55
+  bool VisitSymbolRegionValue(const SymbolRegionValue *S) {
+    return Visit(S->getRegion());
+  }
----------------
NoQ wrote:
> Arithmetic is indeed easy, but for example this part requires a much deeper 
> justification.
Well, this is an experiment. I have checked out the Clang Tidy's 
matcher-writing language's framework so I believe their own language is way 
more better, than implementing `hasDescendant()` only. Some kind of framework 
would be neat, but this is what I came up with as the `hasDescendant()` is the 
most powerful matcher in their world.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D70805/new/

https://reviews.llvm.org/D70805



_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
  • [PATCH] D70805: [analyzer] SVa... Csaba Dabis via Phabricator via cfe-commits

Reply via email to