kadircet added a comment. LG. I might be missing some context though, what's the reasoning behind? Because, I think it is not necessary to treat protobufs differently.
It might be sensible to have a more generic `isSymbolFromGeneratedFile` filter, but also for this one I don't see any developments in the near future. ================ Comment at: clang-tools-extra/clangd/Protobuf.cpp:24 + +// To identify whether a proto header is actually generated by proto compiler, +// we check whether it starts with PROTO_HEADER_COMMENT. ---------------- maybe move this comment down below, right before the line ` if (!SM.getBufferData(FID).startswith(PROTO_HEADER_COMMENT))` ================ Comment at: clang-tools-extra/clangd/index/SymbolCollector.cpp:81 -// we check whether it starts with PROTO_HEADER_COMMENT. -// FIXME: make filtering extensible when there are more use cases for symbol -// filters. ---------------- looks like this fixme got dropped Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D73780/new/ https://reviews.llvm.org/D73780 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
