[PATCH] D73734: [Fuchsia] Never link in implicit "system dependencies" of sanitizer runtimes

[Roland McGrath via Phabricator via cfe-commits]

mcgrathr updated this revision to Diff 241560.
mcgrathr added a comment.

builds now.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D73734/new/

https://reviews.llvm.org/D73734

Files:
  clang/lib/Driver/ToolChains/CommonArgs.cpp


Index: clang/lib/Driver/ToolChains/CommonArgs.cpp
===================================================================
--- clang/lib/Driver/ToolChains/CommonArgs.cpp
+++ clang/lib/Driver/ToolChains/CommonArgs.cpp
@@ -583,6 +583,12 @@
 
 void tools::linkSanitizerRuntimeDeps(const ToolChain &TC,
                                      ArgStringList &CmdArgs) {
+  if (TC.getTriple().isOSFuchsia()) {
+    // Fuchsia never needs these.  Any sanitizer runtimes with system
+    // dependencies use the `.deplibs` feature.
+    return;
+  }
+
   // Force linking against the system libraries sanitizers depends on
   // (see PR15823 why this is necessary).
   CmdArgs.push_back("--no-as-needed");



Index: clang/lib/Driver/ToolChains/CommonArgs.cpp
===================================================================
--- clang/lib/Driver/ToolChains/CommonArgs.cpp
+++ clang/lib/Driver/ToolChains/CommonArgs.cpp
@@ -583,6 +583,12 @@
 
 void tools::linkSanitizerRuntimeDeps(const ToolChain &TC,
                                      ArgStringList &CmdArgs) {
+  if (TC.getTriple().isOSFuchsia()) {
+    // Fuchsia never needs these.  Any sanitizer runtimes with system
+    // dependencies use the `.deplibs` feature.
+    return;
+  }
+
   // Force linking against the system libraries sanitizers depends on
   // (see PR15823 why this is necessary).
   CmdArgs.push_back("--no-as-needed");

_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits