MyDeveloperDay added a comment. Nit: Could you add an entry for ReleaseNotes.rst and regenerate the ClangFormatStyleOption.rst with the docs/tools/dump_style.py
================ Comment at: clang/unittests/Format/FormatTestJS.cpp:1229 " (param): param is {\n" - " a: SomeType\n" + " a: SomeType;\n" " }&ABC => 1)\n" ---------------- mprobst wrote: > MyDeveloperDay wrote: > > is this correct? > Yes, type definitions should use `;` if you hadn't added this to the test would it have added a "," ? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D73354/new/ https://reviews.llvm.org/D73354 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits