gribozavr2 added inline comments.
================ Comment at: clang-tools-extra/clang-tidy/bugprone/UseAfterMoveCheck.cpp:387 + unless(inDecltypeOrTemplateArg()), + unless(hasAncestor(cxxNoexceptExpr()))) .bind("call-move"); ---------------- Quuxplusone wrote: > What about `sizeof`, `alignof`, `requires`, `typeid`, and other such > unevaluated contexts? Shouldn't there be a common way to spell "this > expression is unevaluated"? (I don't know if there is or not.) +1 to adding handling and tests for other unevaluated contexts. ================ Comment at: clang-tools-extra/test/clang-tidy/checkers/bugprone-use-after-move.cpp:1276 +namespace PR44667 { +#define REQUIRE(expr) (void)(expr); +struct S {}; ---------------- Is the macro a necessary part of this test? If not, can it be removed? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D73441/new/ https://reviews.llvm.org/D73441 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits