tra added a comment. > If user sets HIP_DEVICE_LIB_PATH, this line in HIP.cpp > addDirectoryList(DriverArgs, LibraryPaths, "-L", "HIP_DEVICE_LIB_PATH"); > adds -L<value of env var HIP_DEVICE_LIB_PATH> to LibraryPaths. -L is > needed since otherwise addDirectoryList will insert an extra empty string. > However, the -L must be stripped before checking for existence in addBCLib.
The fact that "-I" and "-L" are prepended to the paths is an implementation detail. IMO it would be better to fix addDirectoryList() so it can deal with empty prefixes, and document it in the CommonArgs.h. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D73299/new/ https://reviews.llvm.org/D73299 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
