rsmith added inline comments.
================
Comment at: clang/include/clang/Basic/LangOptions.def:124
ENUM_LANGOPT(LaxVectorConversions, LaxVectorConversionKind, 2,
- LaxVectorConversionKind::All, "lax vector conversions")
+ LaxVectorConversionKind::Integer, "lax vector conversions")
LANGOPT(ConvergentFunctions, 1, 1, "Assume convergent functions")
----------------
Looks like you picked up an unrelated change here; please revert this.
================
Comment at: clang/lib/Frontend/InitPreprocessor.cpp:389
+ if (LangOpts.CPlusPlus2a)
Builder.defineMacro("__cpp_concepts", "201707L");
----------------
I think everything is done other than P0848, so according to
https://isocpp.org/std/standing-documents/sd-6-sg10-feature-test-recommendations#__cpp_concepts
the appropriate value to use here is `201907L`.
================
Comment at: clang/www/cxx_status.html:884
<td><a href="https://wg21.link/p0734r0";>P0734R0</a></td>
- <td rowspan="9" class="none" align="center">No</td>
+ <td rowspan="9" class="full" align="center">Clang 10</td>
</tr>
----------------
As discussed off-line: I think P0848R3 is not yet done, so that row should be
left as "No" instead of being marked as "Clang 10". (I'm assuming you'll land
https://reviews.llvm.org/D73155 first, so P1616R1 will be done before this goes
in.)
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D73150/new/
https://reviews.llvm.org/D73150
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
