gribozavr2 added inline comments.
================ Comment at: clang-tools-extra/clang-tidy/bugprone/InfiniteLoopCheck.cpp:186 + } + } + ---------------- I think this logic should go into `isChanged()`, similarly to how it handles for loops today. ================ Comment at: clang-tools-extra/clang-tidy/bugprone/InfiniteLoopCheck.cpp:202 + } + } + ---------------- I think this logic should go into `getCondVarNames`. It even seems like the existing logic should work without changes, it is walking all children of a provided statement. Repository: rCTE Clang Tools Extra CHANGES SINCE LAST ACTION https://reviews.llvm.org/D73270/new/ https://reviews.llvm.org/D73270 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
