arphaman added a comment.
Please add a test that exercises path without ARC enabled.
================
Comment at: clang/lib/Sema/SemaExprObjC.cpp:3019
+ if (ReceiverType->isObjCClassType() && !isImplicit &&
+ (!Receiver->isObjCSelfExpr() || !getLangOpts().ObjCAutoRefCount)) {
Diag(Receiver->getExprLoc(),
----------------
NIT: It feels easier to read if the condition is `&&
!(Receiver->isObjCSelfExpr() && getLangOpts().ObjCAutoRefCount)`.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D72747/new/
https://reviews.llvm.org/D72747
_______________________________________________
cfe-commits mailing list
[email protected]
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
