erichkeane added inline comments.
================
Comment at: clang/lib/Sema/SemaChecking.cpp:4479
+ const Expr *Arg = Args[AA->getParamIndex().getASTIndex()];
+ if (!Arg->isTypeDependent() && !Arg->isValueDependent()) {
+ llvm::APSInt I(64);
----------------
Does this need to be isInstantionDependent?
================
Comment at: clang/lib/Sema/SemaChecking.cpp:4489
+ // Alignment calculations can wrap around if it's greater than 2**29.
+ unsigned MaximumAlignment = 536870912;
+ if (I > MaximumAlignment)
----------------
I thought we had this stored somewhere else? We probably should have this be a
constant somewhere in the frontend. I THINK I remember doing a review where I
pulled this value into clang somewhere...
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D72996/new/
https://reviews.llvm.org/D72996
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
