lebedev.ri added a comment.

In D72998#1828559 <https://reviews.llvm.org/D72998#1828559>, @hfinkel wrote:

> Can we, at least, put this constant in a header file so we don't repeat it in 
> several places?


Remember, we can't use `llvm::Value::MaximumAlignment` itself in clang sema.
Which header do you have in mind?

> Also, can we write it as 0x20000000 so that it's more obvious what the value 
> is.

Sure, will do.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D72998/new/

https://reviews.llvm.org/D72998



_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to