wenlei added a comment. @aganea, @hans This patch broke response file expansion for preprocessor via `-Wp` - all our internal builds failed with this patch because we invoke clang with response file passed to preprocessor, e.g. `clang++ ... -Wp,@pp.rsp @cc.rsp`. Looks like we can't just call `ExecuteCC1Tool` directly, because response file expansion happens in `main`, so with this patch, `-Wp,@pp.rsp` won't be expanded properly.
repo: CLANG_SPAWN_CC1=0 clang++ -c -Wp,@a.rsp @a.rsp test.cpp error: error reading '@rr.rsp' 1 error generated. and it works with `CLANG_SPAWN_CC1=1` Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69825/new/ https://reviews.llvm.org/D69825 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
