ymandel marked an inline comment as done. ymandel added a comment. Thanks for the review!
In D72274#1826634 <https://reviews.llvm.org/D72274#1826634>, @gribozavr2 wrote: > In D72274#1826614 <https://reviews.llvm.org/D72274#1826614>, @ymandel wrote: > > > In D72274#1826477 <https://reviews.llvm.org/D72274#1826477>, @gribozavr2 > > wrote: > > > > > The only functional change that I see in this patch is in > > > `clang/lib/Tooling/Transformer/Stencil.cpp`. However, I don't understand > > > how that change in the (deprecated) selection() stencil can affect other > > > stencils. > > > > > > Good point. Actually, `selection` and `text` are still used internally. > > See, for example, lines 301-303 in Stencil.cpp. We deprecated their use > > for clients. > > > Oh, that explains everything. I have to clean up that implementation file... Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72274/new/ https://reviews.llvm.org/D72274 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
