mprobst accepted this revision.
mprobst added inline comments.
This revision is now accepted and ready to land.
================
Comment at: clang/lib/Format/TokenAnnotator.cpp:2717
+ // operator Foo*()
+ // dependant on PointerAlignment style.
+
----------------
typo dependent
================
Comment at: clang/lib/Format/TokenAnnotator.cpp:2722
+ FormatToken *Before = Left.getPreviousNonComment();
+ while (Before && Before->isOneOf(tok::kw_const, tok::kw_volatile)) {
+ Before = Before->getPreviousNonComment();
----------------
how many const and volatile may be there, and is their order fixed?
We also have the `endsSequence` helper on FormatToken that might express the
concept better (`Left.endsSequence(tok::kw_const, tok::kw_volatile) || ...`).
YMMV, with the tokens being optional that might lead to too many alternates to
check for.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D72911/new/
https://reviews.llvm.org/D72911
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
