rnk accepted this revision. rnk added a comment. This revision is now accepted and ready to land.
lgtm, just some test comment tweaks. ================ Comment at: clang/test/CodeGen/exceptions-seh-finally.c:3 +// RUN: %clang_cc1 %s -triple i686-pc-win32 -fms-extensions -emit-llvm -O1 -disable-llvm-passes -o - | FileCheck %s +// RUN: %clang_cc1 %s -triple aarch64-windows -fms-extensions -emit-llvm -O1 -disable-llvm-passes -o - | FileCheck %s ---------------- I guess it would be best to move the comment about why we pass `-O1 -disable-llvm-passes` here. We are doing it to avoid applying optnone and noinline attributes everywhere. ================ Comment at: clang/test/CodeGen/exceptions-seh-finally.c:284-286 -// Look for the absence of noinline. Enum attributes come first, so check that -// a string attribute is the first to verify that no enum attributes are -// present. ---------------- Please leave at least "Look for the absence of noinline." from the original comment. I think I added this test because we used to mark these noinline. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72786/new/ https://reviews.llvm.org/D72786 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
