simon_tatham accepted this revision. simon_tatham added a comment. This revision is now accepted and ready to land.
Hmm. Somewhere in the back of my head is a worry that we may miss an optimization opportunity in cases such as `max(a, abs(b))` where value-range analysis tells us that `a` is known to be positive already. But better a missed optimization than a correctness bug, of course! This patch LGTM. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72830/new/ https://reviews.llvm.org/D72830 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits